WI01041726 - Legacy Control Migration: Fixes#13
Open
Conversation
Change WebBrowser references in WebBrowserSiteBase and WebBrowserEvent to a WeakReference. Temporary fix while waiting for dotnet#13769 (cherry picked from commit 1ca4f6d)
…and fix graphics state restoration in PaintEventArgs (WI00857973)
- Added a new button in MainForm to demonstrate the AnchorLayoutHighDpiRegression. - Refactored Program.cs to set the main method as private and removed unnecessary comments regarding high DPI settings. - Introduced AnchorLayoutHighDpiRegressionTests to validate the behavior of bottom/right-anchored controls in high DPI scenarios. - Created a detailed markdown document outlining the high-DPI regression issues and proposed solutions. - Added compatibility logic in DefaultLayout.AnchorLayoutCompat.cs to handle stale positive anchors and stretch-anchor recovery. - Updated DefaultLayout.cs to integrate the new compatibility checks for anchor information during layout calculations.
…dotnet#33) WI00949199 - form size should be recalculated when menu changes (dotnet#36)
zuizuihao
changed the title
Adil-WTG
requested changes
Apr 2, 2026
| if (command == CommandStateChangeConstants.CSC_NAVIGATEBACK) | ||
| { | ||
| _parent.CanGoBackInternal = enable; | ||
| Parent.CanGoBackInternal = enable; |
There was a problem hiding this comment.
Parent could return null.
Suggested change
| Parent.CanGoBackInternal = enable; | |
| Parent?.CanGoBackInternal = enable; |
| else if (command == CommandStateChangeConstants.CSC_NAVIGATEFORWARD) | ||
| { | ||
| _parent.CanGoForwardInternal = enable; | ||
| Parent.CanGoForwardInternal = enable; |
There was a problem hiding this comment.
`Parent' could return null
Suggested change
| Parent.CanGoForwardInternal = enable; | |
| Parent?.CanGoForwardInternal = enable; |
| Debug.Assert(urlObject is null or string, "invalid url"); | ||
| _haveNavigated = true; | ||
| if (_parent._documentStreamToSetOnLoad is not null && (string?)urlObject == "about:blank") | ||
| if (Parent._documentStreamToSetOnLoad is not null && (string?)urlObject == "about:blank") |
There was a problem hiding this comment.
store 'Parent' to a local variable and use it in this method.
| { | ||
| private readonly WebBrowser _parent; | ||
| private readonly WeakReference<WebBrowser> _parent; | ||
| private WebBrowser Parent |
There was a problem hiding this comment.
As parent could be null now code should be rewritten with this in mind.
| /// Retrieves the WebBrowserBase object set in the constructor. | ||
| /// </summary> | ||
| internal WebBrowserBase Host => _host; | ||
| internal WebBrowserBase Host |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WI01041726 - Legacy Control Migration: Fixes
Not Good Fix: avoid type issue when instantiated from ZBindingContext (WI00826420)
Fixed: comment out Debug.Fail in PaintEventArgs (WI00857973)
Fixed In Winforms: keyboard shortcuts associated with menus not being captured (WI00895180)
Fixed: temporarily fixed WebBrowser memory leak (WI00938771)
Fixed: menu popup events not firing (WI00949199)
Fixed: menu bar size not taken into account in form sizing (WI00949199)
Fixed: menu property change should trigger size update (WI00949199)
Fixed: ToolBar tooltip moving the position of the toolbar (WI00951596)
Fixed: control's anchor info (WI00955507)
Fixed: disappearing Owner Draw MenuItem (WI00948012)
Fixed In Winforms: IT Customs - NET8 NRE on Customs Declaration MISC Tab (WI01005730)